Automatically expand and scroll the streams tree when focusing on an item#5494
Merged
Automatically expand and scroll the streams tree when focusing on an item#5494
Conversation
Contributor
|
There seem to be issues with the visibility check. Example here where the time panel won't scroll even though I cannot see the entity: 24-03-14_09.04.15.patched.mp4(Also I cannot help but notice that there's no selection highlight in the time panel -- wasn't that implemented? I lost track of all the improvements!) |
Member
Author
|
@teh-cmc yeah sorry, this should be marked as draft. There is a bug going on here that I haven't been able to track so far. Edit: fixed. And yeah, "sister-selection" is still on the todo list. It will make that focus feature much nicer. |
# Conflicts: # Cargo.lock # Cargo.toml
# Conflicts: # Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for expanding and scrolling to the focus item in the Streams view. It also adds expanding/scrolling the Blueprint tree when focusing on a component.
ScrollAreabugs: leaking scroll target and broken animation to target offset emilk/egui#4174TODO:
focus_scroll_works.mp4
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io