Improve how the root container is displayed and handled in the blueprint tree#4989
Merged
Improve how the root container is displayed and handled in the blueprint tree#4989
Conversation
Wumpf
approved these changes
Feb 1, 2024
Member
Wumpf
left a comment
There was a problem hiding this comment.
I'm new to this code and I must say these are some really pretty ascii arts explaining me what's going on. Very newcomer friendly!
This design makes way more sense and execution looks solid!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR changes how the root container is displayed and handled:
Other than that, it still behaves mostly as other containers (in particular, it can be selected and edited).
Some changes were needed in the drag-and-drop code, making the "if-statement-of-death" incrementally more complicated, sadly.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io