Notes on spatial transforms & spatial topology#4908
Merged
Conversation
jleibs
approved these changes
Jan 25, 2024
Comment on lines
+33
to
+34
| ## Null transforms | ||
| Null transforms are handled like identity transforms, the same as not logging a transform at all. |
Contributor
There was a problem hiding this comment.
One thing we might want to introduce is a union-arm like: Transform3D::Unknown which acts as a 3D transform topologically speaking, but will return some kind of "Temporarily disconnected" result during runtime evaluation and prevent the reprojection from taking place.
Member
Author
There was a problem hiding this comment.
Hmmmm but we shouldn't make this affect our visualizability calculation I think since as you say the "unreachability" is entirely temporary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
As discussed on Slack, noted down what we decided on spatial transforms. Extended it a bit from there
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io