Primary cache: don't denormalize defaulted component values#4891
Merged
Primary cache: don't denormalize defaulted component values#4891
Conversation
Contributor
Size changes
|
dd80167 to
5b4e1d4
Compare
5bf921d to
bf89c30
Compare
jleibs
reviewed
Jan 25, 2024
| Ok(added_size_bytes) | ||
| } | ||
|
|
||
| /// This will insert an empty slice for a missing component (instead of N `None` values). |
Contributor
There was a problem hiding this comment.
Why do we need to insert/store anything? Can't we just return an empty container from the cache if the component-entry is missing when we try to access it?
Contributor
Author
There was a problem hiding this comment.
We need to keep track of the empty rows so all the component caches can share the same top-level offsets (similar to what we do in the store where we use a Option::<DataCell>::None value for that).
Contributor
There was a problem hiding this comment.
Ahh, for the case of range-queries where only some of the rows are empty?
jleibs
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache will now keep track of missing optional components, and store an empty slice instead of a bunch of
Nonevalues.When queried, an empty shows up as a
Noneoption to the end-user, who can act appropriately.SFM before:
SFM after:
What
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io