Introduce a TimeSeries archetype and use it to control the plot legend#4867
Merged
Introduce a TimeSeries archetype and use it to control the plot legend#4867
Conversation
jleibs
commented
Jan 18, 2024
abey79
approved these changes
Jan 19, 2024
Member
abey79
left a comment
There was a problem hiding this comment.
LGTM but shouldn't the legend stuff be removed from EntityProperties then?
Contributor
Author
Still being used separately in the BarChart -- I'll introduce more Archetypes and remove it in a future PR. |
f83f446 to
d76ed77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is the basic pattern we expect to see for all of these view-configuration type tasks:
This generally seems to be much easier to think about than dealing with the EntityProperties struct as this was handled previously as it's exclusively a contact between the TimeSeries archetype and the TimeSeriesSpaceView implementation.
Open question:
TimeSeriesView?Needs #4609 to land first since I developed there before rebasing to main.
Will be nice to come back and clean this up again once #3384 is done.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io