Subdue container labels to distinguish them from space views#4855
Closed
Subdue container labels to distinguish them from space views#4855
Conversation
30 tasks
Member
|
I don't think this design really worked. It's too hard to distinguish and greying out just the names didn't really communicate that there is something different about this kind of thing |
Member
Author
I agree. I'm not really sure how to go forward from this. Color? That's how macOS/windows deals with that: coloured, very strongly styled icons for containers.
Any icon sub-typing is very discreet:
@martenbjork help! 😅 |
Contributor
|
Should we draft this? |
Member
Author
We actually decided to discard it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
As the title says ☝🏻. Note that the icon still reflects visibility.
Here, the tab widget is visible but not the vertical one:
Selection panel (which currently doesn't reflect visibility state #4854):
Relates to:
Note: this PR piles on debt to be paid off with:
ListItemand useWidgetText's API instead #4802Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io