Skip to content

Subdue container labels to distinguish them from space views#4855

Closed
abey79 wants to merge 1 commit intomainfrom
antoine/subdued-containers
Closed

Subdue container labels to distinguish them from space views#4855
abey79 wants to merge 1 commit intomainfrom
antoine/subdued-containers

Conversation

@abey79
Copy link
Copy Markdown
Member

@abey79 abey79 commented Jan 18, 2024

What

As the title says ☝🏻. Note that the icon still reflects visibility.

Here, the tab widget is visible but not the vertical one:

image

Selection panel (which currently doesn't reflect visibility state #4854):

image

Relates to:

Note: this PR piles on debt to be paid off with:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 18, 2024
@nikolausWest
Copy link
Copy Markdown
Member

I don't think this design really worked. It's too hard to distinguish and greying out just the names didn't really communicate that there is something different about this kind of thing

@abey79
Copy link
Copy Markdown
Member Author

abey79 commented Jan 18, 2024

I don't think this design really worked. It's too hard to distinguish and greying out just the names didn't really communicate that there is something different about this kind of thing

I agree. I'm not really sure how to go forward from this. Color? That's how macOS/windows deals with that: coloured, very strongly styled icons for containers.

image

Any icon sub-typing is very discreet:

image

@martenbjork help! 😅

@abey79 abey79 added do-not-merge Do not merge this PR 💬 discussion labels Jan 18, 2024
@Wumpf Wumpf requested review from Wumpf and removed request for Wumpf January 18, 2024 11:05
@teh-cmc
Copy link
Copy Markdown
Contributor

teh-cmc commented Jan 23, 2024

Should we draft this?

@abey79
Copy link
Copy Markdown
Member Author

abey79 commented Jan 23, 2024

Should we draft this?

We actually decided to discard it.

@abey79 abey79 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💬 discussion do-not-merge Do not merge this PR include in changelog ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants