Skip to content

Resolve spurious blueprint panel group collapsing#4548

Merged
jleibs merged 1 commit intomainfrom
jleibs/stable_blueprint_tree_ids
Dec 15, 2023
Merged

Resolve spurious blueprint panel group collapsing#4548
jleibs merged 1 commit intomainfrom
jleibs/stable_blueprint_tree_ids

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Dec 14, 2023

What

Needed to make the id deterministic since the value of DataResultHandle was basically just a function of how many children the data-result had.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review December 14, 2023 23:47
@jleibs jleibs added ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 14, 2023
@jleibs jleibs changed the title Use the entity_path when determining id for collapsible state of a data-result Resolve spurious blueprint panel group collapsing Dec 14, 2023
@jleibs jleibs merged commit 5254c42 into main Dec 15, 2023
@jleibs jleibs deleted the jleibs/stable_blueprint_tree_ids branch December 15, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing entity from blueprint panel sometimes collapses parent

2 participants