DataLoaders 1: introduce, and migrate to, DataLoaders#4517
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMMIT PER COMMIT!
That's the nasty one... there's always a nasty one 😬
Introduces the
DataLoadertrait, which can load any file, either from a filepath by reading from the local filesystem, or from a pre-loaded file's contents.DataLoaders are run in parallel where possible, and have complete say over what data they are interested in or not (i.e. they are not registered based on an extension, which is very limited in practice).I've decided to commit small example assets for the types we support, cause I feel we really need a fast way of checking whether everything still works from time to time.
It's pretty light but might be controversial, I figure.
Checks:
cargo r -p rerun-cli --no-default-features --features native_viewer -- examples/assets/example.{glb,gltf,obj,jpg,png,rrd}File > Open > examples/assets/*Drag-n-drop > examples/assets/*File > Open > examples/assets/*Drag-n-drop > examples/assets/*Part of a series of PRs to make it possible to load any file from the local filesystem, by any means, on web and native:
DataLoaders 0: utility for hierarchicalEntityPathfrom file path #4516DataLoaders 1: introduce, and migrate to,DataLoaders #4517DataLoaders 2: add text-basedDataLoader(.txt,.md) #4518DataLoaders 3: add 3D point cloudDataLoader(.ply) #4519DataLoaders 4: add generic folderDataLoader#4520DataLoaders 5: add support for external binaryDataLoaders (PATH) #4521Checklist