Skip to content

Rename name to identifier for SpaceViewClass and, well, IdentifiedViewSystem#4406

Merged
abey79 merged 2 commits intomainfrom
antoine/name-to-identifier
Nov 30, 2023
Merged

Rename name to identifier for SpaceViewClass and, well, IdentifiedViewSystem#4406
abey79 merged 2 commits intomainfrom
antoine/name-to-identifier

Conversation

@abey79
Copy link
Copy Markdown
Member

@abey79 abey79 commented Nov 30, 2023 •
edited
Loading

What

As per #4393 (comment)

Review per commit: we could merge either or both.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 30, 2023
@abey79 abey79 merged commit b33cbc4 into main Nov 30, 2023
@abey79 abey79 deleted the antoine/name-to-identifier branch November 30, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abey79 @emilk