Export TensorBuffer & TensorDimension to rerun namespace#4331
Merged
Conversation
1 task
emilk
reviewed
Nov 26, 2023
Member
emilk
left a comment
There was a problem hiding this comment.
Let's do it in Python and Rust as well then, for consistency. It would be nice to just generate this list of exported things btw, but let's not go too crazy.
Makes user code/example a little bit nicer
Was there anything in the repo that became nicer?
Member
Author
Forgot to link: This is about the todo notes that were added in |
Member
Author
It is super inconsistent right now which types we export where 🤔 |
Member
Author
|
rust and cpp are easy to make the same. leaving python out of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
What it says on the tin. Makes user code/example a little bit nicer
Checklist