Merged
Conversation
Member
|
This looks really nice! Great job! |
…ataCell knows how to build itself from loggable (and registers types in the process)
49f4f9e to
c5f807a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
& refactor
rerun::Loggableto be only producing an thearrow::Array.This further aligns Rust and C++ apis which can be best seen in the new example which looks very similar to its rust counterpart \o/
DataCelltook over part of the job thatrerun::Loggablehad so far: type registration and putting together theDataCell-to_data_cellgot renamed toto_arrowfor this purpose. Everything else after that just clicked into place :).Did a few manual runs of the log benchmark to ensure that this didn't regress anything.
Checklist