Skip to content

[C++] Rename rerun::ComponentBatch to rerun::Collection (and related constructs)#4236

Merged
Wumpf merged 2 commits intomainfrom
andreas/cpp/rerun-collection-rename
Nov 15, 2023
Merged

[C++] Rename rerun::ComponentBatch to rerun::Collection (and related constructs)#4236
Wumpf merged 2 commits intomainfrom
andreas/cpp/rerun-collection-rename

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Nov 15, 2023

What

Not much else has changed yet except some doc massaging. First step towards solving

rerun::Collection will evolve from here on and be the corner piece of our zero copy & component adaptability strategy (just like ComponentBatch is already!)

This was originally opened on the wrong branch by accident:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added enhancement New feature or request 🚜 refactor Change the code, not the functionality sdk-cpp C/C++ API specific include in changelog labels Nov 15, 2023
@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented Nov 15, 2023

Got already approved as part of the previous PR at #4225 which was further ahead in the git history than it was supposed to.

Just waiting for CI now, then merging

@Wumpf Wumpf merged commit b3f0ff4 into main Nov 15, 2023
@Wumpf Wumpf deleted the andreas/cpp/rerun-collection-rename branch November 15, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request include in changelog 🚜 refactor Change the code, not the functionality sdk-cpp C/C++ API specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant