[C++] Rename rerun::ComponentBatch to rerun::Collection (and related constructs)#4236
Merged
[C++] Rename rerun::ComponentBatch to rerun::Collection (and related constructs)#4236
rerun::ComponentBatch to rerun::Collection (and related constructs)#4236Conversation
Member
Author
|
Got already approved as part of the previous PR at #4225 which was further ahead in the git history than it was supposed to. Just waiting for CI now, then merging |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Not much else has changed yet except some doc massaging. First step towards solving
rerun::Collectionwill evolve from here on and be the corner piece of our zero copy & component adaptability strategy (just like ComponentBatch is already!)This was originally opened on the wrong branch by accident:
rerun::ComponentBatchtorerun::Collection(and related constructs) #4225Checklist