Reduce rerun_c library size (by depending on fewer unnecessary crates)#4147
Merged
Reduce rerun_c library size (by depending on fewer unnecessary crates)#4147
Conversation
4f9e827 to
7ce3939
Compare
63ba5f2 to
a68bba4
Compare
jleibs
approved these changes
Nov 6, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
Nice. This seems logical to me and paves an improved path for standalone packages for adding new types without cluttering the sdk/rerun_c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
re_log_typesno longer depends onre_typesre_sdkno longer depends onre_memoryre_sdkno longer depends onre_typesreruncrateDependency graph before:

Dependency graph now:

Graphs via:
cargo depgraph --all-deps --workspace-only --all-features --dedup-transitive-deps | dot -Tpng > deps.pngRerun C checks via:
cargo build -p rerun_c --release && ls -l target/release/librerun_c.aChecklist