Skip to content

C++ Windows CI#4110

Merged
Wumpf merged 5 commits intomainfrom
andreas/cpp/msvc-ci
Nov 1, 2023
Merged

C++ Windows CI#4110
Wumpf merged 5 commits intomainfrom
andreas/cpp/msvc-ci

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Nov 1, 2023 •
edited
Loading

What

  • Fixes C++ Windows/MSVC full support + testing on CI #3756
  • Run VS2022 C++ tests as part of pull request CI.
    • decided to go pull request for now because it's very easy to break C++ things on one compiler while you're on any of the other compilers
    • This is a 12min windows job currently which also has to build rerun_c for windows first
    • in the future we'd ideally just skip most C++ jobs if no cpp/hpp/h file has changed!
  • Enable warnings as errors for msvc

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf changed the title Andreas/cpp/msvc ci C++ Windows CI Nov 1, 2023
@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) 🪟 windows Problems specific to the Windows OS include in changelog labels Nov 1, 2023
@Wumpf Wumpf marked this pull request as ready for review November 1, 2023 10:20
@Wumpf Wumpf added this to the 0.10.1 milestone Nov 1, 2023
emilk
emilk approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Wumpf Wumpf merged commit 7bf3153 into main Nov 1, 2023
@Wumpf Wumpf deleted the andreas/cpp/msvc-ci branch November 1, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

+1 more reviewer

@jleibs jleibs jleibs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🪟 windows Problems specific to the Windows OS

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

C++ Windows/MSVC full support + testing on CI

3 participants

@Wumpf @emilk @jleibs