Update the "Events and Timelines" docs page#4039
Merged
Conversation
jleibs
reviewed
Oct 27, 2023
jleibs
approved these changes
Oct 27, 2023
Member
|
rebase on |
Member
Author
|
Arg and of course it fails linting... we really need #4047 |
emilk
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
That doc page was named "Events and Timelines", but no mention was made of what event are. This PR fixes this, as well as add rust and c++ version of the example snippet.
The code snippets are incomplete and thus excluded from roundtrip tests. Supporting hide-able stubs would allow fixing this (https://github.com/rerun-io/landing/issues/515).
Checklist