C++ ingest string views instead of const char* (almost) everywhere#4023
Merged
C++ ingest string views instead of const char* (almost) everywhere#4023
Conversation
emilk
approved these changes
Oct 26, 2023
Member
emilk
left a comment
There was a problem hiding this comment.
LGTM, except for the obvious bug :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
std::string_viewor similar for strings #3834Makes api nicer to use. Trickles down to C api making us technically more flexible!
The only big drawback is that
std::string_view((const char*)nullptr)is undefined behavior 🤦Checklist