Add C++ API for set_default_enabled to globally enable/disable recording streams.#4014
Merged
Add C++ API for set_default_enabled to globally enable/disable recording streams.#4014
set_default_enabled to globally enable/disable recording streams.#4014Conversation
set_default_enabled to globally enable/disable recording streams.
teh-cmc
reviewed
Oct 26, 2023
teh-cmc
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a very minimal singleton config system and an API to toggle the state of default_recordings. Specifically this makes it possible for a user to globally disable default recordings, and then enable them via the RERUN environment variable.
Checklist