Skip to content

C++ time & timeless support#3838

Merged
Wumpf merged 19 commits intomainfrom
andreas/cpp/time-support
Oct 13, 2023
Merged

C++ time & timeless support#3838
Wumpf merged 19 commits intomainfrom
andreas/cpp/time-support

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Oct 12, 2023

What

Introduces time methods to C/C++, timeless logging and ports the clock example.

Originally, I planned to expose a Timeline struct type to C but this actually created more surface for errors to occur, so I instead expose the three time setter for seconds/nanos/sequences separately, making the code much easier to reason with.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added sdk-cpp C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 12, 2023
@emilk emilk self-requested a review October 12, 2023 12:25
Copy link
Copy Markdown
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Wumpf Wumpf force-pushed the andreas/cpp/time-support branch from 0505e65 to 4faedf3 Compare October 12, 2023 16:02
@Wumpf Wumpf merged commit 4556d4f into main Oct 13, 2023
@Wumpf Wumpf deleted the andreas/cpp/time-support branch October 13, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md sdk-cpp C/C++ API specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C++ implement logging with timestamps

2 participants