Don't create 3D space view if there's a pinhole camera at the origin#3821
Merged
Don't create 3D space view if there's a pinhole camera at the origin#3821
Conversation
Wumpf
reviewed
Oct 11, 2023
Comment on lines
+72
to
+75
| // TODO(andreas): It would be nice to just return `AutoSpawnHeuristic::AlwaysSpawn` here | ||
| // but AlwaysSpawn does not prevent other `SpawnClassWithHighestScoreForRoot` instances | ||
| // from being added to the view. | ||
| score += 100.0; |
Member
There was a problem hiding this comment.
wondering if this could be AlwaysSpawn now, huh. Let's not do that now 😄
Wumpf
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves: #3820
Checklist