Optimize out unnecessary joins when querying archetypes#3377
Merged
Conversation
Contributor
Author
|
I'm seeing more low-hanging fruit in that function... gimme a sec... 👀 |
Contributor
Author
|
Alright, grabbed all the milliseconds I could: 62ms -> 40ms to build the point3d view in OPF. Now let's see how all that behaves with the new mesh archetype. |
This was referenced Sep 20, 2023
Merged
Contributor
Author
emilk
reviewed
Sep 20, 2023
f40d3a3 to
b0410c8
Compare
emilk
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says; see the commits for details, it's pretty trivial.
Going from a ~62ms space view build time to ~40ms in the OPF example, so pretty nice gains overall.
OPF, before:
OPF, after:
What
Checklist