Fix Boxes2D view not processing annotation labels#3331
Merged
Conversation
50944d6 to
85a4a01
Compare
Wumpf
approved these changes
Sep 15, 2023
Member
Wumpf
left a comment
There was a problem hiding this comment.
thanks! I'll unify all of these label handlings in a follow-up soon'ish
Comment on lines
+25
to
+26
| /// If the number of points in the batch is > max_labels, don't render box labels. | ||
| pub max_labels: usize, |
Member
There was a problem hiding this comment.
I think actually we should drop this weirdness; user has zero control over that stuff. If they spam us with labels we should just spam back.
In fact I believe we only ever did this for points
I'll take care of it in a follow-up, don't worry about it here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says.
Requires #3323, which made the underlying bug visible to begin with.
What
Checklist