Skip to content

C++ as_components style & splatting#3258

Merged
Wumpf merged 20 commits intomainfrom
andreas/cpp/splats
Sep 8, 2023
Merged

C++ as_components style & splatting#3258
Wumpf merged 20 commits intomainfrom
andreas/cpp/splats

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Sep 7, 2023

What

Trigger of this PR was the inability to deal with mono components like DrawOrder -> need splatting -> don't want to implement splatting separately for components & archetype -> implement as_components-style

Quick throw-away test for splatting radius on the random point demo:
image

Checklist

@Wumpf Wumpf added sdk-cpp C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 7, 2023
@Wumpf Wumpf force-pushed the andreas/cpp/splats branch from 9b7f7b8 to a89568a Compare September 7, 2023 17:22
@teh-cmc teh-cmc self-requested a review September 8, 2023 06:42
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall 👍 Just a handful of minor things.

@Wumpf Wumpf merged commit 1488bd5 into main Sep 8, 2023
@Wumpf Wumpf deleted the andreas/cpp/splats branch September 8, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md sdk-cpp C/C++ API specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archetypes should implement as_components - C++ First-class citizenry for indicator components - C++ C++ component splatting support

2 participants