Conversation
9b7f7b8 to
a89568a
Compare
teh-cmc
approved these changes
Sep 8, 2023
Contributor
teh-cmc
left a comment
There was a problem hiding this comment.
Looks great overall 👍 Just a handful of minor things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
as_component_lists, we return a vector of type erased component arrays that know how to serialize themselves, dubbedAnonymousComponentListfor now.AnonymousComponentList. This smells very much like we should have actual inheritance somewhere, but it's a bit tricky since we want to extract pointer out of arbitrary list types, giving rise to the type awareComponentList. Overall the approach here tries to mimic Rust but ultimately misses the target, since, well this is not Rust. To be revisited, maybe it is just a naming issue!as_component_listsis very slightly dubious since they're not backed by data but ofc indicator components don't have any data to begin with 🤷log_components) need to be optional non-owning (& mappable) #3050Trigger of this PR was the inability to deal with mono components like
DrawOrder-> need splatting -> don't want to implement splatting separately for components & archetype -> implement as_components-styleQuick throw-away test for splatting radius on the random point demo:

Checklist