Clamp time panel height to avoid visual glitches#3169
Merged
Conversation
This was referenced Aug 31, 2023
emilk
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #3152
Note to reviewer: I had to resort to some semi-hack to measure the height of "everything above the viewport", i.e. windows title bar vs. heading banner on web (which are significantly different). That's the
screen_header_heightvariable. Open to suggestion to make that cleaner.Checklist
I've included a screenshot or gif (if applicable)I have tested demo.rerun.io (if applicable)PR demo somehow failed, here is the demo for commit 8fb79bf