Merged
Conversation
…m` for all view query things now
…erialize blueprint
3 tasks
359e562 to
60540f7
Compare
jleibs
reviewed
Aug 25, 2023
crates/re_space_view_spatial/src/contexts/annotation_context.rs
Outdated
Show resolved
Hide resolved
crates/re_viewer_context/src/space_view/space_view_class_registry.rs
Outdated
Show resolved
Hide resolved
jleibs
approved these changes
Aug 25, 2023
Member
|
|
This reverts commit a399c0a.
Contributor
Size changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
(.. at least fixes it well enough for the moment I reckon)
Improves both the per space view rendering and the space view adding heuristic. In particular on the later there's still significant gains to be made.
Most importantly we should be scaling now much better with number of added systems.
Went fairly early with the decision to have the primary datastructure to pass around be a
Map<System, Vec<Entity>>(conceptual) instead of the other way round since this is what we need in the systems most of the time.This is another step towards a stronger contract of systems specifying what components they will query ahead of time!
The way it is implemented on thr (rename from
BlueprintTree💥)SpaceViewContentsalso paves the way for ui selection of systems for a given entity path which complements the ongoing work on our new data ingestion interfaces.Testcase:
examples/python/open_photogrammetry_format/main.py --no-frames, fully reset viewer and then hiding NOT REMOVING the points (the world/pcl entity) and deselecting them.(The bold marked pieces are very important as they have an influence on what heuristics run - see #3077)
Before:
After:
(release runs, averaged over a bunch of frames on my M1 Max)
Highlights:
AppState::show: 24.0ms ➡️ 14.6msSpaceViewBlueprint::scene_ui: 4.9ms ➡️ 2.6msViewport::on_frame_start: 15.2ms ➡️ 7.4msdefault_created_space_view: 12.7ms ➡️ 5.1ms(slight number discrepancies from the screenshot are due to doing a different run)
Draft todo: Code sanity check. Suspecting some heuristics might be slightly broken, need to go through examples
Checklist