Skip to content

C++ put test types out of the SDK and into the test executable#3007

Merged
Wumpf merged 5 commits intomainfrom
andreas/cpp/separate-test-types
Aug 18, 2023
Merged

C++ put test types out of the SDK and into the test executable#3007
Wumpf merged 5 commits intomainfrom
andreas/cpp/separate-test-types

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Aug 16, 2023 •
edited by github-actions bot
Loading

What

Moves out all affix-fuzzer and co. testing types of the actual SDK.

While working on that...

  • I figured out why warnings from arrow headers showed up only sometimes: When Arrow isn't added explicitely as a dependency, CMake doesn't seem to declare it as system header which normally suppresses warnings (as you can imagine this got really bad now when adding more cpps that include arrow to the test library). Obvious workaround is to add arrow explicitly to the text executable.
  • internal include paths got shorter/more natural in some cases. I had to make the Includes utility more clever in order to support types outside of the sdk, so we got this almost for free :)

Checklist

@Wumpf Wumpf added the sdk-cpp C/C++ API specific label Aug 16, 2023
@Wumpf Wumpf force-pushed the andreas/cpp/separate-test-types branch 2 times, most recently from c9625b9 to 3c0480a Compare August 17, 2023 12:41
@jleibs jleibs self-requested a review August 18, 2023 14:38
jleibs
jleibs approved these changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@Wumpf Wumpf force-pushed the andreas/cpp/separate-test-types branch 2 times, most recently from 3c2e850 to e14032d Compare August 18, 2023 15:01
@Wumpf Wumpf force-pushed the andreas/cpp/separate-test-types branch from e14032d to 4169a3a Compare August 18, 2023 16:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2023

Size changes

Name Previous Current Change
Wasm (none) 13.499 MB +100%
JS (none) 107.698 KB +100%
arkit_scenes.rrd (none) 41660.537 KB +100%
detect_and_track_objects.rrd (none) 59524.213 KB +100%
dicom_mri.rrd (none) 64877.032 KB +100%
dna.rrd (none) 781.585 KB +100%
human_pose_tracking.rrd (none) 56968.432 KB +100%
plots.rrd (none) 258.045 KB +100%
structure_from_motion.rrd (none) 7083.767 KB +100%

@Wumpf Wumpf merged commit fe3fcff into main Aug 18, 2023
@Wumpf Wumpf deleted the andreas/cpp/separate-test-types branch August 18, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleibs jleibs jleibs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sdk-cpp C/C++ API specific

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wumpf @jleibs