Codegen'd deserialization refactoring: correctness, error handling, helpers#2953
Merged
Codegen'd deserialization refactoring: correctness, error handling, helpers#2953
Conversation
edecb6a to
0996869
Compare
This was
linked to
issues
Aug 10, 2023
jleibs
approved these changes
Aug 10, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
This is such a huge improvement in legibility and error handling. Nice work!
c6ac602 to
a97a4b8
Compare
7d60daf to
eb45e2c
Compare
Contributor
Author
|
Integrated your suggestions, looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit by commit
This actually ended up looking more like a massive clean up more than a refactoring per-se, as I've found out after experimenting with a couple alternative designs that what we currently have is actually pretty nice in many aspects.
It just needed a lot of cleaning up is all!
TL;DR:
Specifically this fixes:
By side-effect, this makes transforms work with the C++ SDK:
Benchmarks vs
mainjust in case:What
Checklist