Skip to content

Getting workspace deps to a somewhat better state#2026

Merged
teh-cmc merged 10 commits intomainfrom
cmc/workspace_deps_conendrum
May 4, 2023
Merged

Getting workspace deps to a somewhat better state#2026
teh-cmc merged 10 commits intomainfrom
cmc/workspace_deps_conendrum

Conversation

@teh-cmc
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc commented May 3, 2023 •
edited by github-actions bot
Loading

  • Always disable default feature flags for all re_ crates when working within the workspace
  • Make examples independent of workspace shenanigans and easily copy pastable

Fixes #2024 (see over there for more explanations...)

$ cd rerun_py && cargo tree -i re_viewer
re_viewer v0.6.0-alpha.0 (/home/cmc/dev/rerun-io/rerun/crates/re_viewer)
└── rerun v0.6.0-alpha.0 (/home/cmc/dev/rerun-io/rerun/crates/rerun)
    └── rerun_py v0.6.0-alpha.0 (/home/cmc/dev/rerun-io/rerun/rerun_py)

$ cargo tree --no-default-features -i re_viewer
warning: nothing to print.

PR Build Summary: https://build.rerun.io/pr/2026

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) labels May 3, 2023
@teh-cmc teh-cmc marked this pull request as ready for review May 3, 2023 09:02
@teh-cmc teh-cmc added sdk-python Python logging API sdk-rust Rust logging API labels May 3, 2023
@emilk emilk self-requested a review May 4, 2023 07:07
emilk
emilk approved these changes May 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we should also add a lint to look for (and forbid) workspace in any example Cargo.toml so we don't regress here

@teh-cmc teh-cmc mentioned this pull request May 4, 2023
Merged
@teh-cmc
Copy link
Copy Markdown
Contributor Author

teh-cmc commented May 4, 2023 •
edited
Loading

added workspace deps linter -- expecting clock example to fail CI in 3..2..1...

edit: yeeee
image

@teh-cmc teh-cmc merged commit cd4fa0f into main May 4, 2023
@teh-cmc teh-cmc deleted the cmc/workspace_deps_conendrum branch May 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) sdk-python Python logging API sdk-rust Rust logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rerun_py always enables all of rerun's default-flags

2 participants

@teh-cmc @emilk