Fix compilation of rerun without native_viewer feature#1771
Closed
rasmusgo wants to merge 1 commit intorerun-io:mainfrom
Closed
Fix compilation of rerun without native_viewer feature#1771rasmusgo wants to merge 1 commit intorerun-io:mainfrom
rerun without native_viewer feature#1771rasmusgo wants to merge 1 commit intorerun-io:mainfrom
Conversation
rerun without native_viewer feature
Member
|
The problem is the CI is running |
1 task
emilk
reviewed
Apr 5, 2023
| } | ||
| #[cfg(not(feature = "native_viewer"))] | ||
| { | ||
| anyhow::bail!("Can't start viewer - rerun was compiled without the 'native_viewer' feature"); |
Member
There was a problem hiding this comment.
I think this is the wrong fix - streaming rrd files from http has nothing to do with the native viewer - we should instead move stream_rrd_from_http_to_channel to some other crate imho
Member
|
Thanks for the PR - I'll fix it in #1772 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build with
--no-default-features --features sdk. This should have been caught by the CI but wasn't. Is this related to--locked?Checklist