Merged
Conversation
teh-cmc
approved these changes
Mar 31, 2023
Comment on lines
+26
to
+27
| /// Displays an overlay for debugging picking. | ||
| pub show_picking_debug_overlay: bool, |
Comment on lines
+219
to
+221
| // It is possible that some frames we don't get a picking result and the frame after we get several. | ||
| // We need to cache the last picking result and use it until we get a new one or the mouse leaves the screen. | ||
| // (Andreas: On my mac this *actually* happens in very simple scenes, I get occasional frames with 0 and then with 2 picking results!) |
Base automatically changed from
andreas/re_renderer/improved-readback-data-handling
to
main
March 31, 2023 09:32
…rlier in the ui build up process
0a38698 to
36a065e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #807
Screen.Recording.2023-03-30.at.19.57.30.mov
Puts GPU based picking into production by implementing it for meshes. We're not done with the overall ticket #1615 yet since this cuts a few corners.
Apart from only being used for meshes we're missing:
Checklist