Conversation
emilk
reviewed
Mar 11, 2023
emilk
reviewed
Mar 11, 2023
emilk
approved these changes
Mar 15, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some very real issues with dataframe sorting that cost me some hair when implementing tests for the defunct #1527.
This does not fix #894, as there is in fact a very real bug in the GC and the flakiness is justified; but that's a topic for another PR that I'll cover tomorrow when I can finally focus on GC stuff.
(github won't let me not close #894 now that I've mentioned it apparently... I'll re-open it manually once this is merged...)