datastore: disable compaction (fixes 2x memory issue)#1535
Merged
Conversation
jleibs
approved these changes
Mar 9, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
Should we consider handling this with a change to the default DataStoreConfig instead so that it could be enabled more easily for testing going forward?
| // TODO(cmc): Compaction is disabled until we implement batching. | ||
| // See https://github.com/rerun-io/rerun/pull/1535 for rationale. | ||
| // | ||
| // This has no noticeable impact on importance. |
Contributor
There was a problem hiding this comment.
Can we back up this claim with data?
This was referenced Mar 9, 2023
Merged
This was referenced Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables bucket-level compaction aka. archiving until we support batching, thereby fixing the 2x memory issue. See below for rationale.
This doesn't impact garbage collection nor performance in any noticeable way.
Before:
After:
Closes #1397
The original long form rationale:
See also this internal slack thread.