feat: Add validation for required fields in fbs files#11429
Merged
Wumpf merged 4 commits intorerun-io:mainfrom Oct 6, 2025
Merged
feat: Add validation for required fields in fbs files#11429Wumpf merged 4 commits intorerun-io:mainfrom
required fields in fbs files#11429Wumpf merged 4 commits intorerun-io:mainfrom
Conversation
Wumpf
requested changes
Oct 6, 2025
Member
Wumpf
left a comment
There was a problem hiding this comment.
thanks, but this also actually requires to run pixi run codegen and clean up where that assert is violated
Also, it would be nicer to not right out crash but instead log an error on the reporter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Closes #2634
What
Panic during detection of
requiredfields infbsschema