You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
space_view.rs: SpaceViewBlueprint::on_frame_start still passes per_system_entities to on_frame_start. Move to PerSystemDataResults.
Not doing this since PerSystemEntities might line up better with store-view-managed things in the future
space_view_heuristics.rs: default_created_space_views still passes per_system_entities to auto_spawn_heuristic. Move to PerSystemDataResults.
Not doing this since PerSystemEntities might line up better with store-view-managed things in the future
Fix performance regressions for heuristics #4490space_view_heuristics.rs: We run a query for every candidate space view during creation. This is extremely painful when we have a bunch of image spaces, for example. Need to be much smarter about how we evaluate candidates.
space_view_heuristics.rs: Removed context_collections from systems_per_required_components because otherwise annotation-contexts trigger incorrect heuristics. Need to figure out what this broke.
I believe this has been refactored away.
space_view_highlights.rs: Group hover/selection needs to look-up and walk query result
The initial introducing of DataQuery (#4311) left plenty of things to still clean up:
space_view.rs:SpaceViewBlueprint::on_frame_startstill passesper_system_entitiestoon_frame_start. Move toPerSystemDataResults.space_view_heuristics.rs:default_created_space_viewsstill passesper_system_entitiestoauto_spawn_heuristic. Move toPerSystemDataResults.space_view_heuristics.rs: Removed context_collections fromsystems_per_required_componentsbecause otherwise annotation-contexts trigger incorrect heuristics. Need to figure out what this broke.