Merged
Conversation
… compressed image formats
33 tasks
emilk
reviewed
Oct 30, 2023
Member
|
Works great on Mac using pixi! |
emilk
approved these changes
Oct 31, 2023
| namespace rerun_vrs { | ||
|
|
||
| std::string add_quotes(const std::string& str) { | ||
| return "\"" + str + "\""; |
Member
There was a problem hiding this comment.
this should ideally also escape any already existing quotes in the string
Member
There was a problem hiding this comment.
it's a bit annoying though that even we think we need such a util in the example. Should be part of the sdk then
Wumpf
approved these changes
Oct 31, 2023
| namespace rerun_vrs { | ||
|
|
||
| std::string add_quotes(const std::string& str) { | ||
| return "\"" + str + "\""; |
Member
There was a problem hiding this comment.
it's a bit annoying though that even we think we need such a util in the example. Should be part of the sdk then
Co-authored-by: Andreas Reich <r_andreas2@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested only with aria_recording.vrs from the sample dataset in here (bottom of page) so far.
TODOs