I think this is a faster commentRegExp#1538
Closed
lsa2127291 wants to merge 1 commit into
Closed
Conversation
Member
|
Summary of the change, for my future reference, just remove the parens from the regexp. Looks like the style checking failed, you can run it locally after doing an npm install by running I will put this in consideration for 2.2.1, but want to evaluate it more. It may take a couple weeks for me to conclude it. What would help is any info on if the parens removal affects the kinds of strings that match. |
Member
|
This is addressed in #1582. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through the test,I think this is a faster way to clear comment.