Update Python 2 examples in docs to Python 3#525
Merged
JonathanHuot merged 1 commit intorequests:masterfrom Feb 25, 2024
Merged
Update Python 2 examples in docs to Python 3#525JonathanHuot merged 1 commit intorequests:masterfrom
JonathanHuot merged 1 commit intorequests:masterfrom
Conversation
Contributor
|
Will be happy to merge any code drop of py2; thanks for this one already ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently came across this library and saw that it still had Python 2 references in the docs. I saw #523 was open, so I went ahead and updated the documentation to use Python 3 examples.
Once #523 is merged this could be merged as well.
(Out of scope, but leaving this here for now, could make this a separate issue)
Now that we're dropping Python <=3.7 there are a lot of Python 3 related changes and quality of life improvements we can now make:
I wouldn't mind working on these in my free time if we decide these would be useful!