Skip to content

Update google.rst#454

Merged
jtroussard merged 2 commits intorequests:masterfrom
likesclever:Update-google.rst
Jan 1, 2022
Merged

Update google.rst#454
jtroussard merged 2 commits intorequests:masterfrom
likesclever:Update-google.rst

Conversation

@likesclever
Copy link
Copy Markdown
Contributor

@likesclever likesclever commented Sep 8, 2021

JonathanHuot
JonathanHuot approved these changes Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanHuot JonathanHuot added this to the 1.3.1 milestone Nov 2, 2021
jtroussard
jtroussard requested changes Nov 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtroussard jtroussard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With regards to making updates to the example files, can we introduce a new contribution requirement to include some sort of verification?

@likesclever
Copy link
Copy Markdown
Contributor Author

likesclever commented Nov 12, 2021 •
edited by jtroussard
Loading

Do i need to do anything else

Is there a way to verify these changes work? Screen shot, demo, or something else maybe?

@likesclever
Copy link
Copy Markdown
Contributor Author

likesclever commented Nov 16, 2021

Do i need to do anything else

Is there a way to verify these changes work? Screen shot, demo, or something else maybe?

Without "openid", the "email" attribute is not returned:
{'id': '102430716320508450299', 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'}
After adding "openid", the "email" attribute will be returned:
{'id': '102430716320508450299', 'email': 'mr.wangjianhui@gmail.com', 'verified_email': True, 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'}

@jtroussard
Copy link
Copy Markdown
Contributor

jtroussard commented Nov 17, 2021

Do i need to do anything else

Is there a way to verify these changes work? Screen shot, demo, or something else maybe?

Without "openid", the "email" attribute is not returned: {'id': '102430716320508450299', 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'} After adding "openid", the "email" attribute will be returned: {'id': '102430716320508450299', 'email': 'mr.wangjianhui@gmail.com', 'verified_email': True, 'name': '王健辉', 'given_name': '健辉', 'family_name': '王', 'picture': 'https://lh3.googleusercontent.com/a-/AOh14GgIPx4ZiXyy-rEPCQu9ARptOQmXar2qwh1RIcqy=s96-c', 'locale': 'zh-CN'}

was the example broken before?

@jtroussard
Copy link
Copy Markdown
Contributor

jtroussard commented Jan 1, 2022 •
edited
Loading

Was able to verify this updates results in successfully implementation of the library, making small non-functional change to trigger new pipeline checks.

Please go here and authorize: https://accounts.google.com/o/oauth2/v2/auth?response_type=code&client_id=304001012802-0ees1230msjhq4mg42bbup0qsqv392nd.apps.googleusercontent.com&redirect_uri=https%3A%2F%2Fdeveloperslifefor.me&scope=openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile&state=inBDO80eGx3xRKsioqW5gKwUcJomhi&access_type=offline&prompt=select_account
Paste the full redirect URL here: https://developerslifefor.me/?state=inBDO80eGx3xRKsioqW5gKwUcJomhi&code=4%2F0AX4XfWgtLtppeb5C_WTRvOh1AJPfIdh9nG-IRcyWPZ51ZVBSpq_ndSPZikqvRCqXh_LoIQ&scope=email+profile+openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile&authuser=0&prompt=consent#
b'{\n "id": "106402832064790875123",\n "email": ,\n "verified_email": true,\n "name": "Jacques Troussard",\n "given_name": "Jacques",\n "family_name": "Troussard",\n "picture": "https://lh3.googleusercontent.com/a-/AOh14Gg4tG2gqM2Gd9uGj4ab9Kg_MoQ4bIsKk--G1ZgXIE4=s96-c",\n "locale": "en"\n}\n'

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 1, 2022

Coverage Status

Coverage increased (+0.08%) to 90.239% when pulling e92087f on mrwangjianhui:Update-google.rst into 46f886c on requests:master.

jtroussard
jtroussard approved these changes Jan 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtroussard jtroussard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtroussard jtroussard merged commit 00e8156 into requests:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanHuot JonathanHuot JonathanHuot approved these changes

@jtroussard jtroussard jtroussard approved these changes

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

1.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@likesclever @jtroussard @coveralls @JonathanHuot