Skip to content

Add Support for OAuth Mutual TLS (draft-ietf-oauth-mtls)#389

Merged
singingwolfboy merged 4 commits intorequests:masterfrom
danielfett:master
Dec 19, 2019
Merged

Add Support for OAuth Mutual TLS (draft-ietf-oauth-mtls)#389
singingwolfboy merged 4 commits intorequests:masterfrom
danielfett:master

Conversation

@danielfett
Copy link
Copy Markdown

OAuth Mutual TLS is on track to become an IETF standard. It will be used in many high-risk scenarios, including Open Banking (see OpenID FAPI), e-health applications, and e-government applications. This patch adds support for client authentication via MTLS.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 29, 2019

Coverage Status

Coverage decreased (-0.03%) to 90.462% when pulling a8f45a7 on danielfett:master into 792f184 on requests:master.

@singingwolfboy
Copy link
Copy Markdown
Member

This looks like a great start! However, we need an automated test covering this change, and an entry in the HISTORY.rst file.

Let me know if you have any difficulty with writing this test. I think you'll want to mock the requests library, and verify that it's being called with the cert parameter.

@danielfett
Copy link
Copy Markdown
Author

Added tests and HISTORY.rst entry.

@singingwolfboy
Copy link
Copy Markdown
Member

Looks great! Thank you! 🎉

@singingwolfboy singingwolfboy merged commit 29ba9af into requests:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants