feat: implement treat-canonical-paths-equal flag #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AkihiroSuda merged 1 commit into reproducible-containers:master from thesayyn:canonical_paths

Mar 5, 2024

Contributor

thesayyn commented Mar 2, 2024

When tars extracted, essentially `` (no prefix) , / (leading slash), `./` (dot slash) all mean the same thing, relative to `chroot` of the container.

This flag implements a feature where these paths are considered the same.

I didn't add any tests, as i didn't know where to put them.

thesayyn force-pushed the canonical_paths branch from ffc0c5c to bcadcde Compare

March 2, 2024 00:24

AkihiroSuda reviewed

View reviewed changes

cmd/diffoci/commands/diff/diff.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

cmd/diffoci/commands/diff/diff.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

pkg/diff/diff.go Show resolved Hide resolved

Member

AkihiroSuda commented Mar 4, 2024

Could you squash the commits?

thesayyn force-pushed the canonical_paths branch from a3d25ab to 03c204e Compare

March 4, 2024 23:32

Contributor Author

thesayyn commented Mar 4, 2024

Done

AkihiroSuda reviewed

View reviewed changes

cmd/diffoci/commands/diff/diff.go Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

cmd/diffoci/commands/diff/diff.go Outdated Show resolved Hide resolved


          feat: implement --treat-canonical-paths-equal flag

11e3981

Signed-off-by: thesayyn <thesayyn@gmail.com>

rename flag

Update cmd/diffoci/commands/diff/diff.go

Co-authored-by: Akihiro Suda <suda.kyoto@gmail.com>
Signed-off-by: thesayyn <thesayyn@gmail.com>

thesayyn force-pushed the canonical_paths branch from e760f0a to 11e3981 Compare

March 5, 2024 00:14

Contributor Author

thesayyn commented Mar 5, 2024

Done, PTAL

AkihiroSuda approved these changes

View reviewed changes

Member

AkihiroSuda left a comment

Thanks

AkihiroSuda changed the title ~~feat: implement --canonical-paths flag~~ feat: implement treat-canonical-paths-equal flag

AkihiroSuda merged commit be86d38 into reproducible-containers:master

chenrui333 mentioned this pull request

diffoci 0.1.5 Homebrew/homebrew-core#181366

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet