Skip to content

[python] Fix bug parsing extras#322

Merged
blast-hardcheese merged 7 commits intomainfrom
dstewart/python-extras-bug
Dec 20, 2024
Merged

[python] Fix bug parsing extras#322
blast-hardcheese merged 7 commits intomainfrom
dstewart/python-extras-bug

Conversation

@blast-hardcheese
Copy link
Contributor

Why

image

What changed

  • Break ((?:extras)?(?:version)?) into (extras)?(version?)
  • Thread PkgCoordinates through to Add instead of the limited resolution PkgSpec
  • Explicitly integrate Extra into pep440Join instead of just hoping everything works

Test plan

  • CI

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner December 20, 2024 01:07
@blast-hardcheese blast-hardcheese requested review from airportyh and removed request for a team December 20, 2024 01:07
@blast-hardcheese blast-hardcheese force-pushed the dstewart/python-extras-bug branch from 2e4d327 to 28c7acf Compare December 20, 2024 01:10
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) December 20, 2024 01:12
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Dec 20, 2024
@blast-hardcheese blast-hardcheese merged commit 09a4de8 into main Dec 20, 2024
@blast-hardcheese blast-hardcheese deleted the dstewart/python-extras-bug branch December 20, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants