Merged
Conversation
Why === * We don't use python and node for upm, we use Go * We're getting reports we don't need to address on dependencies in our test suite. * It doesn't matter if there is an outdated or insecure dep in our test suite, since we aren't even running python or node code What changed === * Limit dependabot to 0 PRs in pip and npm ecosystems Test plan === * Stop seeing dependabot PRs for node and python
| package-ecosystem: "npm" | ||
| schedule: | ||
| interval: "monthly" | ||
| open-pull-requests-limit: 0 |
Contributor
There was a problem hiding this comment.
why this instead of just deleting the whole package-ecosystem block for the languages we don't care about?
Collaborator
Author
There was a problem hiding this comment.
I'm pretty sure dependabot is turned on org-wide so it was still doing updates without us even having this file.
blast-hardcheese
approved these changes
Sep 11, 2024
Contributor
blast-hardcheese
left a comment
There was a problem hiding this comment.
Either way is fine, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What changed
Test plan