This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Fix conflict between two select_one items with same name but different groups#1105
Merged
Fix conflict between two select_one items with same name but different groups#1105
Conversation
GraysonNull
approved these changes
Mar 5, 2020
dexhorthy
reviewed
Mar 5, 2020
Contributor
dexhorthy
left a comment
There was a problem hiding this comment.
What if both select_one config items are in the same group? Or is group here not referring to the top level groups key?
Member
Author
|
@dexhorthy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Did
Fix conflict between two select_one items with same name but different groups
How I Did it
add the group to the input id in the ConfigRadio component
How to verify it
Description for the Changelog
Picture of a Ship (not required but encouraged)