This repository was archived by the owner on Mar 24, 2023. It is now read-only.
marshal boolstrings like 'no' with quotes in helm values file#1100
Merged
laverya merged 1 commit intoreplicatedhq:masterfrom Mar 2, 2020
Merged
Conversation
divolgin
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Did
Changed the yaml renderer for the helm settings file to render the string
noas"no"and notno(which helm interprets as a boolean)How I Did it
How to verify it
Description for the Changelog
Picture of a Ship (not required but encouraged)