This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Merged
Conversation
sgalsaleh
approved these changes
Nov 19, 2019
Default is unused since value is always set, but default can still cause error when not a boolean. update version
c4e023c to
9128610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default is unused since value is always set, but default can still cause
error when not a boolean.
What I Did
Fix console error about using string "true" as default to checkbox.
How I Did it
Removed the default.
How to verify it
Check for console errors with this config:
Description for the Changelog
Removed unused default from checkbox config item.
Picture of a Ship (not required but encouraged)