This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Merged
Conversation
seperate 'lint' and 'test' CI steps 'go test' and 'go build' should use files from the 'vendor' folder pact tests should use go modules use vendor in 'go vet' run golangci-lint on each subdir in pkg individually in ci skip running golangci-lint on integration tests go-bindata and go-modules do not get along
divolgin
reviewed
Aug 28, 2019
|
|
||
| } | ||
| } | ||
| // func (d *V1Routes) requireKustomize() gin.HandlerFunc { |
divolgin
reviewed
Aug 28, 2019
|
|
||
| } | ||
| } | ||
| // func (d *V1Routes) requireUnfork() gin.HandlerFunc { |
divolgin
reviewed
Aug 28, 2019
hack/get_build_deps.sh
Outdated
| go get github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs | ||
| go get -u github.com/jteeuwen/go-bindata/go-bindata | ||
| go get -u github.com/gordonklaus/ineffassign | ||
| GO111MODULE=auto go get -u github.com/jteeuwen/go-bindata/go-bindata |
Member
There was a problem hiding this comment.
auto is kind of mysterious. can this be either off or on? i think off is what you want here.
Member
Author
There was a problem hiding this comment.
Probably a better idea, yeah
use 'GO111MODULE=off' not 'auto' to disable remove commented out unused functions
divolgin
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Did
Added golangci to our CI testing. Fixed the errors it identified. Fixes #1056.
How I Did it
Lots of code fixes.
How to verify it
the
lintjob runs successfullyDescription for the Changelog
Picture of a Ship (not required but encouraged)