This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Render filemodes properly#1050
Merged
laverya merged 5 commits intoreplicatedhq:masterfrom Aug 26, 2019
Merged
Conversation
debug.log override filemodes to clarify octal vs bin issues
divolgin
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Did
File modes for the inline asset type (and those that rely on it, such as the various terraform assets) are set with chmod after writing to avoid umask issues. Fixes #1014, along with docs fixes
How I Did it
After writing the file, run
chmodto ensure the correct mode is set.How to verify it
Unit tests have been added.
Description for the Changelog
File modes are set properly on rendered
inlineassets regardless of umask values.Picture of a Ship (not required but encouraged)