Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

feat:delete ollama models#458

Merged
joseplayero merged 17 commits intoreorproject:mainfrom
Bhavyajain21:feat/delete-ollama-models
Oct 18, 2024
Merged

feat:delete ollama models#458
joseplayero merged 17 commits intoreorproject:mainfrom
Bhavyajain21:feat/delete-ollama-models

Conversation

@Bhavyajain21
Copy link
Copy Markdown
Collaborator

@Bhavyajain21 Bhavyajain21 commented Oct 17, 2024

fixes #452
/claim #452

@Bhavyajain21 Bhavyajain21 requested review from joseplayero and samlhuillier and removed request for samlhuillier October 17, 2024 04:45
Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request implements the ability to delete Ollama models, addressing issue #452 by adding new IPC handlers and UI components for model deletion.

  • Added new IPC handlers in electron/main/llm/ipcHandlers.ts for fetching available models and deleting LLMs
  • Exposed new functions deleteLLM and getAvailableModels to the renderer process in electron/preload/index.ts
  • Updated DefaultLLMSelector component in src/components/Settings/LLMSettings/DefaultLLMSelector.tsx to include a delete option for Ollama models
  • Modified useLLMConfigs hook in src/components/Settings/LLMSettings/hooks/use-llm-configs.ts to allow direct updates to LLM configurations
  • Consider improving error handling and user feedback for model deletion operations

4 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

@Bhavyajain21 Bhavyajain21 changed the title feat/delete ollama models feat:delete ollama models Oct 17, 2024
@Bhavyajain21
Copy link
Copy Markdown
Collaborator Author

@joseplayero , I've worked on the addressed review comments. Please take a look!

@joseplayero joseplayero merged commit 393805d into reorproject:main Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow for deletion of ollama models

2 participants