This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Added Send Button and Dropdown in Chatbot Homelayout#382
Merged
joseplayero merged 9 commits intoreorproject:mainfrom Aug 29, 2024
Merged
Conversation
…and dropdown to select the llm model from get-llm-configs
…chatbot homelayout
There was a problem hiding this comment.
PR Summary
This pull request adds a send button and LLM model selection dropdown to the chat interface, addressing issue #381. Key changes include:
- Modified
src/components/Chat/ChatMessages.tsxto implement new UI elements and functionality - Added LLM model fetching and selection state management in
ChatMessages.tsx - Updated
electron/main/llm/llmConfig.tsto include a fallback for empty LLM configurations - Exposed
ipcRenderer.invokeinelectron/preload/index.tsfor main process communication
Key points to consider:
- Ensure proper error handling for LLM model fetching and selection
- Verify the implementation of the send button logic in
ChatMessages.tsx - Review the security implications of exposing
ipcRenderer.invokeinindex.ts - Check if the UI layout matches the requested design in the issue description
- Confirm that the context selector button has been repositioned as specified
3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings
… llm from dropdown while sending message
…n llm model from dropdown
joseplayero
suggested changes
Aug 27, 2024
Collaborator
joseplayero
left a comment
There was a problem hiding this comment.
thanks for making @itsdheerajdp
you do not need to interface the invoke function to the renderer process. you need to only call the function await window.llm.getLLMConfigs() to get the llm configs and the equivalent get/set default llm function
also please keep the code clean and consistent, state variables go at the top of a component
Contributor
Author
|
@joseplayero I made the requested changes , kindly check it out .. |
joseplayero
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #381
Fixes : #381
After adding the changes , now the home layout looks like below