Recommitting bitwise, readme, and header changes.#5
Merged
rentzsch merged 1 commit intorentzsch:semver-1.xfrom Mar 25, 2014
Merged
Recommitting bitwise, readme, and header changes.#5rentzsch merged 1 commit intorentzsch:semver-1.xfrom
rentzsch merged 1 commit intorentzsch:semver-1.xfrom
Conversation
Sorry I'm such a git-idiot
Owner
|
Thanks, this is much better. I'll take a deep look at it later. |
Contributor
Author
|
any chance of merging this... i want to do another pull, but hesitate until we can resolve this... i may have made changes to this bitwise implementation since this request, so ask me if theres any questions concerns and ill take a look. |
Owner
|
Sorry it took so long to merge this. I took your NSScanner idea and ran with it, merging it into JREnum itself. I also added bitshifting support while in there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I'm such a git-idiot. Really don't know if I'm doing it right… but I doubt too many people are watching.. so might as well practice :)