fix: add textarea support

remy · remy · commit 6e3c86dd6aa6 · 2015-08-22T11:15:04.000+01:00
Fixes #8
diff --git a/lib/bind.js b/lib/bind.js
@@ -167,7 +167,7 @@ var Bind = (function Bind(global) {
         // matched from the selector (set up below), that checks
         // the node type, and either sets the input.value or
         // element.innerHTML to the value
-        var valueSetters = ['SELECT', 'INPUT', 'PROGRESS'];
+        var valueSetters = ['SELECT', 'INPUT', 'PROGRESS', 'TEXTAREA'];
 
         if (value === null || value === undefined) {
           if (valueSetters.indexOf(elements[0].nodeName) !== -1) {
@@ -238,7 +238,7 @@ var Bind = (function Bind(global) {
         // let's make the binding two way...
         // note that this doesn't support event delegation
         forEach(elements, function (element) {
-          if (element.nodeName === 'INPUT' || element.nodeName === 'SELECT') {
+          if (element.nodeName === 'INPUT' || element.nodeName === 'SELECT' || element.nodeName === 'TEXTAREA') {
             var oninput = function () {
               // we set a dirty flag against this dom node to prevent a
               // circular update / max stack explode
diff --git a/test/two-way.browser.js b/test/two-way.browser.js
@@ -46,6 +46,11 @@ describe('two way data bind', function () {
     assert.ok(found === 3, 'found ' + found);
   });
 
+  it('should update textarea elements', function () {
+    var ta = document.querySelector('textarea');
+    assert.equal(ta.value, data.body, 'textarea was updated');
+  });
+
   it('should update data based on element changes', function (done) {
     var node = document.querySelector('input.score');
     node.value = 10;
diff --git a/test/two-way.html b/test/two-way.html
@@ -3,4 +3,6 @@
 <progress class="score" min=0 max=100 value=0>
 
 <span class="name">Remy</span>
-<input class="name">
+<input class="name">
+
+<textarea class="body"></textarea>
